Core: Add missing REST endpoint definitions #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajreid21
changed the title
ebyhr
reviewed
Dec 12, 2024
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Dec 12, 2024
nastra
reviewed
Dec 12, 2024
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Dec 12, 2024
nastra
reviewed
Dec 12, 2024
Fokko
approved these changes
Dec 13, 2024
ajreid21
force-pushed
the
add-missing-rest-endpoint-definitions
branch
from
e4e3935 to
24e94d6
Compare
ajreid21
commented
Dec 13, 2024
| @@ -138,11 +138,13 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog | |||
| ImmutableSet.<Endpoint>builder() | |||
| .add(Endpoint.V1_LIST_NAMESPACES) | |||
| .add(Endpoint.V1_LOAD_NAMESPACE) | |||
| .add(Endpoint.V1_NAMESPACE_EXISTS) | |||
There was a problem hiding this comment.
I also added namespace exists to the default list
|
@nastra I addressed the comments and added the new checks if you want to take another look. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there were some definitions missing in the REST Endpoint class (most notably entries for tableExists and the new loadCredentials endpoints).
Added the following definitions in that class:
Added the tableExists endpoint to the list of default endpoints.
It doesn't appear that the REST catalog impl actually uses the namespaceExists or viewExists endpoints and instead falls back to the session and view session catalog impls which loads the namespace/view to check if exists -- is there a reason the REST catalog impl doesn't use the exists endpoints?