Spark3.5: Resolve IDENTIFIER FIELDS with merge-on-read bug #11757
+765
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
601madman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When IDENTIFIER FIELDS are set, and
merge-on-readmode is used, a validation error occurs due to incorrect metadata schema checks.Solution
Adjusted the
calculateMetadataSchema()method inSparkScanBuilderto avoid validating identifier fields in metadata columns.Tests
Added unit tests in
TestMergeOnReadWithIdentifierFieldsDelete、TestMergeOnReadWithIdentifierFieldsMergeandTestMergeOnReadWithIdentifierFieldsUpdateto validate the fix.Closes #11709