Core: Fix numeric overflow of timestamp nano literal #11775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/timestamp-ns
branch
from
5228ca6 to
efe1d14
Compare
| @@ -300,8 +300,7 @@ public <T> Literal<T> to(Type type) { | |||
| case TIMESTAMP: | |||
| return (Literal<T>) new TimestampLiteral(value()); | |||
| case TIMESTAMP_NANO: | |||
| // assume micros and convert to nanos to match the behavior in the timestamp case above | |||
| return new TimestampLiteral(value()).to(type); | |||
| return (Literal<T>) new TimestampNanoLiteral(value()); | |||
There was a problem hiding this comment.
This change seems correct to me, the previous behavior for this was to assume the value was in microseconds and then pass that through to TimestampLiteral but that can overflow and does not actually represent a nanosecond timestamp!
Comment on lines
113
to
115
| assertThat(Literal.of(400000L).to(TimestampNanoType.withoutZone()).toByteBuffer().array()) | ||
| .isEqualTo(new byte[] {0, -124, -41, 23, 0, 0, 0, 0}); | ||
| .isEqualTo(new byte[] {-128, 26, 6, 0, 0, 0, 0, 0}); | ||
| assertThat(Literal.of(400000L).to(TimestampNanoType.withZone()).toByteBuffer().array()) |
There was a problem hiding this comment.
I'm a bit confused how the original assertion was passing? Shouldn't have this always been equivalent to {-128, 26, 6, 0, 0, 0, 0, 0}?
| @@ -107,6 +108,28 @@ public void testTimestampMicrosToDateConversion() { | |||
| assertThat(dateOrdinal).isEqualTo(-1); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testTimestampNanoWithLongLiteral() { | |||
There was a problem hiding this comment.
could we also add a case for withZone?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic leads to overflow when we pass timestamp nanos long value.