Avro: Support default values for generic data #11786
Conversation
| case "time-micros": | ||
| return GenericReaders.times(); | ||
|
|
||
| case "timestamp-micros": |
There was a problem hiding this comment.
does there need to be case for nanos as well?
There was a problem hiding this comment.
There does, but adding the timestamp nanos read path is a separate PR.
There was a problem hiding this comment.
I noticed that we have this string all over the place, probably a good idea to make a constant for it: https://github.com/search?q=repo%3Aapache%2Ficeberg+timestamp-micros+language%3AJava&type=code&l=Java
We can also do that in a separate PR.
rdblue
changed the title
rdblue
force-pushed
the
avro-support-default-values-generic
branch
from
f3cd33a to
a9896a4
Compare
| /** | ||
| * @deprecated will be removed in 2.0.0; use {@link PlannedDataReader} instead. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Most of the changed files in this PR are to avoid using this class now that it is deprecated.
There was a problem hiding this comment.
Checked, and didn't find any usage anymore 👍
| /** | ||
| * @deprecated will be removed in 2.0.0; use {@link PlannedDataReader} instead. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Checked, and didn't find any usage anymore 👍
| case "time-micros": | ||
| return GenericReaders.times(); | ||
|
|
||
| case "timestamp-micros": |
There was a problem hiding this comment.
I noticed that we have this string all over the place, probably a good idea to make a constant for it: https://github.com/search?q=repo%3Aapache%2Ficeberg+timestamp-micros+language%3AJava&type=code&l=Java
We can also do that in a separate PR.
| ((LogicalTypes.Decimal) logicalType).getScale()); | ||
|
|
||
| case "uuid": | ||
| return ValueReaders.uuids(); |
There was a problem hiding this comment.
Separate PR, but I think we also need to take the physical type into account: https://github.com/apache/avro/blob/main/doc/content/en/docs/%2B%2Bversion%2B%2B/Specification/_index.md#uuid
First Avro only supported UUIDs stored as strings, but now also as fixed[16].
| */ | ||
| public static <D> RawDecoder<D> create( | ||
| org.apache.iceberg.Schema readSchema, | ||
| Function<org.apache.iceberg.Schema, DatumReader<D>> readerFunction, |
This implements default values in the Avro generic reader.