Spark 3.4: Add view support to SparkSessionCatalog #11797
+251
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
spark34-views-session-catalog-support
branch
2 times, most recently
from
debf181 to
a2186e4
Compare
nastra
force-pushed
the
spark34-views-session-catalog-support
branch
from
a2186e4 to
142cbea
Compare
nastra
commented
Dec 17, 2024
| @@ -169,9 +169,9 @@ public void testCreateTable() { | |||
|
|
|||
| @Test | |||
| public void showView() { | |||
| sql("DROP VIEW IF EXISTS %s", "test"); | |||
There was a problem hiding this comment.
this test started to fail only in Spark 3.4 when backporting the view changes to SparkSessionCatalog. There is some funkiness going on with the spark_catalog in Spark 3.4 tests where the spark_catalog is reusing some settings from a previous test run. I'll investigate that separately and for now decided to move the DROP to the end of the test (and aligned the same thing for the Spark 3.5 SmokeTest.
The TLDR of this test failure is:
- a previous catalog config created a view named
test - the next test configuration tries to drop this view where the catalog type is
hive - Hive fails when trying to load the view in order to see if it exists here due to the view not being an iceberg view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #11388