Spark 3.4: Backport support for default values #11987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
spark-3.4-default-values
branch
from
2d91c71 to
fc4943e
Compare
rdblue
commented
Jan 17, 2025
|
|
||
| File testFile = temp.newFile(); | ||
| Assert.assertTrue("Delete should succeed", testFile.delete()); | ||
| OutputFile outputFile = new InMemoryOutputFile(); |
There was a problem hiding this comment.
Spark 3.5 tests have been ported to JUnit 5, but 3.4 and 3.3 had not been. This required a few changes that I tried to keep to a minimum. This is one example, where the base class uses a Unit 4 TemporaryFolder that is not initialized for JUnit 5 parameterized tests.
Using InMemoryOutputFile here and in a couple other test suites avoided the need to port tests in #11811 to JUnit 5.
There was a problem hiding this comment.
Yeah I compared it side by side with the original, I think the changes made are reasonable
rdblue
commented
Jan 17, 2025
| @@ -62,8 +62,7 @@ public void writeAndValidateRepeatingRecords() throws IOException { | |||
|
|
|||
| private void writeAndValidateRecords(Schema schema, Iterable<InternalRow> expected) | |||
| throws IOException { | |||
| final File testFile = temp.newFile(); | |||
| Assert.assertTrue("Delete should succeed", testFile.delete()); | |||
| final File testFile = temp.resolve("test").toFile(); | |||
There was a problem hiding this comment.
This test suite also hit issues with JUnit 4 so I ported all the AvroDataTest suites to JUnit 5.
amogh-jahagirdar
approved these changes
Jan 17, 2025
|
Thanks @rdblue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports support for default values from 3.5.
Each PR is backported as a separate commit: #11299, #11803, #11811, #11815, and #11832.