[1.8.x] Fix versions in LICENSE/NOTICE #12365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
changed the title
nastra
reviewed
Feb 21, 2025
| @@ -219,7 +219,7 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens | |||
|
|
|||
| -------------------------------------------------------------------------------- | |||
|
|
|||
| Group: io.netty Name: netty-buffer Version: 4.1.112.Final | |||
| Group: io.netty Name: netty-buffer Version: 4.1.115.Final | |||
There was a problem hiding this comment.
can we fix the same in kafka-connect files as well in this PR?
There was a problem hiding this comment.
Yes, sure. Let me group all change in this PR.
There was a problem hiding this comment.
also in https://github.com/apache/iceberg/blob/1.8.x/gradle/libs.versions.toml#L73 we're using 4.1.117.Final btw
There was a problem hiding this comment.
Yes, but it's what I see in the aws-bundle dependencies (on 1.8.x branch):
$ ./gradlew :iceberg-aws-bundle:dependencies|grep -i netty-buffer
| | +--- io.netty:netty-buffer:4.1.115.Final
| | | +--- io.netty:netty-buffer:4.1.115.Final (*)
20e4259 to
e46c68e
Compare
jbonofre
changed the title
jbonofre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 1.8.1 RC0 vote ...