Core: rewrite file if to a different output spec #14383
Open
+49
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when rewrite to a different spec, if there is only one small file unless rewrite-all, this file won't be able to rewrite if it does not also it won't meet any other criteria.
but when write to a different spec, we do want the spec align with the storage layout. so it's better check this situation and rewrite the file.
this specifically addressed an issue when we do in-table rollup to rewrite files to a coarser partition. in this case we don't want to rewrite-all but also think it's better to make the output file path align with the spec.