Core: Change removal of deprecations to 1.12.0 #14392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Oct 22, 2025
|
|
||
| /** | ||
| * @deprecated will be removed in 2.0.0, use {@link #WRITE_DATA_LOCATION} instead. | ||
| * @deprecated will be removed in 1.12.0, use {@link #WRITE_DATA_LOCATION} instead. |
There was a problem hiding this comment.
I'm a bit hesitant removing table properties earlier, since that would mean a behavioral change
nastra
reviewed
Oct 22, 2025
|
|
||
| /** | ||
| * @deprecated will be removed in 2.0.0. Use {@link | ||
| * @deprecated will be removed in 1.12.0. Use {@link |
There was a problem hiding this comment.
this one should be fine to remove before 2.0.0, since the property was only moved to a different class
nastra
reviewed
Oct 22, 2025
| private ThreadPools() {} | ||
|
|
||
| /** | ||
| * @deprecated Use {@link SystemConfigs#WORKER_THREAD_POOL_SIZE WORKER_THREAD_POOL_SIZE} instead; |
There was a problem hiding this comment.
Suggested change
| * @deprecated Use {@link SystemConfigs#WORKER_THREAD_POOL_SIZE WORKER_THREAD_POOL_SIZE} instead; | |
| * @deprecated Use {@link SystemConfigs#WORKER_THREAD_POOL_SIZE} instead; |
nastra
reviewed
Oct 22, 2025
| /** | ||
| * @deprecated Use {@link SystemConfigs#WORKER_THREAD_POOL_SIZE WORKER_THREAD_POOL_SIZE} instead; | ||
| * will be removed in 2.0.0 | ||
| * will be removed in 1.12.0 |
There was a problem hiding this comment.
this should be ok to remove earlier as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.