Core: Avro logical timestamp-millis support #14401
Open
+199
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avro-logicla-timestamp-ms
3 tasks
nastra
reviewed
Oct 29, 2025
| return ChronoUnit.NANOS.addTo(EPOCH, nanosFromEpoch).toLocalDateTime(); | ||
| } | ||
|
|
||
| public static LocalDateTime timestampFromMillis(long millisFromEpoch) { |
There was a problem hiding this comment.
please add tests for anything that's new to TestDateTimeUtil
| } | ||
| return GenericWriters.timestampNanos(); | ||
|
|
||
| case "timestamp-millis": |
There was a problem hiding this comment.
there should be a test that exercises this path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
This PR addresses the issue #12395
I've contributed a slightly modified version of the original PR addressing this issue.
The differences are:
PlannedDataReaderto account for the deprecation ofDataReadertimestamp-millisis handled independently oftimestamp-microsto account for data files written outside of iceberg.I tested this locally on a small avro based hive table that was migrated to iceberg and queried via a
IcebergGenerics:readscan:IllegalArgumentException: Unknown logical type: org.apache.hive.iceberg.org.apache.avro.LogicalTypes$TimestampMillisissue