API: Use unsigned byte-wise comparison to fix UUID comparison bug #14500
+492
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java's UUID.compareTo() uses signed comparison of most significant bits and least significant bits, which is not compliant with RFC 4122, RFC 9562. This causes incorrect ManifestEntry and ManifestFile filtering/pruning in the presence of UUID filters.
Author
|
Thanks for handling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14216
The problem is described in the issue as well as in the dev mailing list post.
The changes proposed in the PR take a simple approach to fix the comparisons bug. This directly addresses correctness issues at both
ManifestEntryas well asManifestFilefiltering. Note that the changes make UUID values comparison forward-compatible, but compliant with UUID RFCs.