-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flink: Backport #8553 to v1.15, v1.16 #9139
Conversation
CC: @nastra, @nk1506 - When backporting changes, please make sure that all of the changes as similar as possible. After fixing the backport differences caused by previous backports I had a clean backport of #8553 to 1.16. Flink 1.15 missing a feature, so I had to improvise there. See c09aab0 CC: @stevenzwu |
TBH, I do not really understand your comment here 😞 To decrease the turnaround time, I have created 3 PRs, and you can decide which one we should use to move forward:
If someone wants to understand better the contents of the actual backport commit of #8553, the 27333e3 is a merge of the clean backport (67d5cdc), and the required v1.15 related fixes (c09aab0) which are needed as Flink v1.15 has a missing feature used by the tests |
@pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too. |
Thanks! |
Merged with specific PRs for the different parts |
Flink: Backport #8553 to v1.15, v1.16