Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink: Backport #8553 to v1.15, v1.16 #9139

Closed
wants to merge 4 commits into from
Closed

Conversation

pvary
Copy link
Contributor

@pvary pvary commented Nov 23, 2023

@pvary
Copy link
Contributor Author

pvary commented Nov 23, 2023

CC: @nastra, @nk1506 - When backporting changes, please make sure that all of the changes as similar as possible.

After fixing the backport differences caused by previous backports I had a clean backport of #8553 to 1.16.

Flink 1.15 missing a feature, so I had to improvise there. See c09aab0

CC: @stevenzwu

@pvary pvary requested a review from nastra November 23, 2023 17:50
@stevenzwu
Copy link
Contributor

@pvary can you separate this out as a separate PR?

Fix backport differences for #8852 (#8877, #8880)

@pvary
Copy link
Contributor Author

pvary commented Nov 24, 2023

@pvary can you separate this out as a separate PR?

Fix backport differences for #8852 (#8877, #8880)

TBH, I do not really understand your comment here 😞

To decrease the turnaround time, I have created 3 PRs, and you can decide which one we should use to move forward:

If someone wants to understand better the contents of the actual backport commit of #8553, the 27333e3 is a merge of the clean backport (67d5cdc), and the required v1.15 related fixes (c09aab0) which are needed as Flink v1.15 has a missing feature used by the tests

@stevenzwu
Copy link
Contributor

@pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too.

@pvary
Copy link
Contributor Author

pvary commented Nov 27, 2023

@pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too.

Thanks!

@pvary
Copy link
Contributor Author

pvary commented Nov 28, 2023

Merged with specific PRs for the different parts

@pvary pvary closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants