IGNITE-24564 Add all existing catalog serializers to a single registry #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-24564
branch
7 times, most recently
from
bf8be64 to
b375122
Compare
xtern
changed the title
xtern
changed the title
AMashenkov
reviewed
Mar 3, 2025
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Mar 3, 2025
AMashenkov
reviewed
Mar 3, 2025
.../org/apache/ignite/internal/catalog/descriptors/CatalogSortedIndexDescriptorSerializers.java
Show resolved
Hide resolved
AMashenkov
reviewed
Mar 3, 2025
...apache/ignite/internal/catalog/storage/serialization/CatalogEntrySerializerProviderImpl.java
Show resolved
Hide resolved
AMashenkov
approved these changes
Mar 5, 2025
korlov42
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24564
CatalogSerializerannotation, with which the serializer version is set. It is mandatory for all catalog serializers and is used to build the serializer registry.CatalogEntrySerializerProviderImpl, which dynamically creates registry of all serializers using CatalogSerilizer annotation.CatalogSerializerTypeDefinitionto be able test dynamic registry creation (without changing enumMarshallableEntryType), (seeCatalogEntrySerializerProviderImplTest)AlterColumnEntry.AlterColumnEntrySerializermoved toAlterColumnEntrySerializers.AlterColumnEntrySerializerV1)CatalogEntrySerializerProviderto obtain desired serializer (instead of using direct reference)DroppedUpdateLogEvent, usages replaced withMarshallableEntry