Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24678 Sql. Introduce heuristic to exclude NLJ when HJ may be applied #5322

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

korlov42
Copy link
Contributor

@korlov42 korlov42 commented Feb 28, 2025

https://issues.apache.org/jira/browse/IGNITE-24678

Performance of queries for which plans have changed remains the same (measured on my laptop, sc=1):

Before
Benchmark          (fsync)  (queryId)  Mode  Cnt     Score    Error  Units
TpchBenchmark.run    false          5  avgt   20  3936.701 ± 24.698  ms/op
TpchBenchmark.run    false          8  avgt   20  3855.864 ± 26.111  ms/op


After
Benchmark          (fsync)  (queryId)  Mode  Cnt     Score    Error  Units
TpchBenchmark.run    false          5  avgt   20  3973.249 ± 21.253  ms/op
TpchBenchmark.run    false          8  avgt   20  3710.407 ± 18.915  ms/op

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@AMashenkov
Copy link
Member

Fix looks ok.
BTW, there are some tests failed because of invalid sort order.
I guess, an another issue with collation trait propagation should be resolved first.

@korlov42 korlov42 merged commit e2140a4 into apache:main Mar 6, 2025
1 check passed
@korlov42 korlov42 deleted the ignite-24678 branch March 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants