Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol #5373

Merged
merged 11 commits into from
Mar 19, 2025

Conversation

lowka
Copy link
Contributor

@lowka lowka commented Mar 7, 2025

Adds Version 2 serializers of catalog objects.

Introduces API for reading/writing CatalogObject CatalogObjectInput / CatalogObjectOutput:

// Single entry
<T extends MarshallableEntry> T readEntry(MarshallableType<T>);
<T extends MarshallableEntry> void writeEntry(MarshallableType<T>, MarshallableEntry);

// List of entries
<T extends MarshallableEntry> List<T> readEntryList(MarshallableType<T>);
<T extends MarshallableEntry> void writeEntryList(MarshallableType<T>, List<T> entries);

// There is a version that handles arrays as well.

Where MarshallableType<T> is a type token that holds typeId + version. It also allows to read/write subclasses to support lists of heterogeneous elements such as VersionedUpdate entries and Schema indexes (see MarshallableType.Builder).

https://issues.apache.org/jira/browse/IGNITE-24698

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka changed the title Ignite 24698 IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol Mar 7, 2025
@lowka lowka force-pushed the ignite-24698 branch 6 times, most recently from 06de16d to efe0cb3 Compare March 11, 2025 13:30
lowka added 3 commits March 17, 2025 14:11
…rialization protocol

Use the term object instead of entry. remove array methods.
Add compact list format to write a list of object of the same type.
@ygerzhedovich ygerzhedovich merged commit 688662c into apache:main Mar 19, 2025
1 check passed
@ygerzhedovich ygerzhedovich deleted the ignite-24698 branch March 19, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants