Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modularization #852

Merged
merged 19 commits into from
May 21, 2024
Merged

Improve modularization #852

merged 19 commits into from
May 21, 2024

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented May 9, 2024 •
edited
Loading

  • Separate the data collection api from the standard collection api (the standard api has a lot of features and the behavior and their default behavior implemented in abstract classes was not always appropriate).
  • Move the data collection api in a dedicated module.
  • Introduce adapters to convert from one api to the other.
  • Move the pmtiles api in a dedicated module.
  • Move the openstreetmap api in a dedicated module.
  • Move the maplibre api in a dedicated module.
  • Make the openstreetmap api use the standard library for coordinate and reference caches.
  • Move the openstreetmap api in a dedicated module.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2024
View reviewed changes
baremaps-data/src/test/java/org/apache/baremaps/data/AppendOnlyLogTest.java
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

class AppendOnlyBufferTest {
class AppendOnlyLogTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces

Unused class: AppendOnlyLogTest is not referenced within this codebase. If not used as an external API it should be removed.
baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataCollection.java Fixed Show fixed Hide fixed
baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataCollection.java Fixed Show fixed Hide fixed
baremaps-data/src/main/java/org/apache/baremaps/data/collection/AppendOnlyLog.java
public void close() {
memory.segment(0).putLong(0, size);
/** {@inheritDoc} */
public long size() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [DataCollection<E>.size](1); it is advisable to add an Override annotation.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2024
View reviewed changes
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/pbf/PbfEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlChangeReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java Fixed Show fixed Hide fixed
@bchapuis bchapuis force-pushed the modularization branch 2 times, most recently from fe96329 to 4c4beae Compare May 17, 2024 11:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bchapuis bchapuis marked this pull request as ready for review May 21, 2024 20:48
@bchapuis bchapuis merged commit 6c7a2bf into main May 21, 2024
8 of 9 checks passed
@bchapuis bchapuis deleted the modularization branch May 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bchapuis