Bundle rebind transformers with blueprints #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
incubator-brooklyn-pull-requests #1439 FAILURE |
Prepare for applying transforms before generating the manifest - need catalog bundles to load transforms.
|
Resolved merge conflicts. |
|
incubator-brooklyn-pull-requests #1442 SUCCESS |
neykov
referenced
this pull request
in sjcorbett/incubator-brooklyn
Jul 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add means for blueprints to register persistence state transformers, applied on rebind. This will shift the responsibility of creating the transforms from the Brooklyn operators to the blueprints developers.
Very useful when managing brooklyn of brooklyns or lots of instances (transparent for the upgrade effector). Works with partial rebind which allows upgrading of entities needing state transforms without restarting the instance.
As a next step I would like to be able to declare the version of the blueprint for which a transform is written, so it is executed only against those versions. I still don't see how to introduce versions in the blueprint classes though - probably best is to link them to the bundle version, needs further investigation.