Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csp for recaptcha #765

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

cw75
Copy link
Contributor

@cw75 cw75 commented Jun 13, 2024

⚠️   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have npm run build and npm run serve locally before submitting this PR
  • I have read through the Contributing Documentation

Summary

This PR attempts to fix the CSP issue that prevents recaptcha from loading.

Does this close any open issues?

Closes xx

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@klesh
Copy link
Contributor

klesh commented Jun 14, 2024

Thanks for the contribution.
I think I might need some context to understand the fix, would you like to fill me in?
I don't see any recaptcha when browsing the website, so, what did you run into and why this can fix your problem?

@klesh klesh merged commit 2321168 into apache:main Jun 14, 2024
1 check passed
@cw75
Copy link
Contributor Author

cw75 commented Jun 14, 2024

Hi @klesh , thanks for merging. Is the website re-deployed with this change already?

@klesh
Copy link
Contributor

klesh commented Jun 17, 2024

Hi, @cw75 , I believe so https://github.com/apache/incubator-devlake-website/actions/runs/9513869931 the CI went through, but I don't know how to verify your patch.

@cw75
Copy link
Contributor Author

cw75 commented Jun 17, 2024

@klesh yeah since the issue cannot be reproduced locally from our end, it's been hard to debug. I made another patch to try to fix it. Could you merge that as well and see if it fixes the issue? If not, I will remove the widget for now. Thanks!

@klesh
Copy link
Contributor

klesh commented Jun 18, 2024

Sure, waiting for the CI to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants