Skip to content

Add tags on projects #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add tags on projects #8334

wants to merge 4 commits into from

Conversation

ArkVex
Copy link

@ArkVex ArkVex commented Mar 13, 2025

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • [yes ] I have read through the Contributing Documentation.
  • [ yes] I have added relevant tests.
  • [yes ] I have added relevant documentation.
  • [ yes] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

This PR introduces a project tagging system, allowing users to assign and manage tags for better organization. It updates the database schema to store tags, enhances the API to support tag-based filtering, and improves the UI for easy tag management. This feature helps tech leads and engineering managers track projects efficiently and create dashboards based on shared tags.

Does this close any open issues?

Closes #8279

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 13, 2025
@dosubot dosubot bot added component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature labels Mar 13, 2025
Copy link
Contributor

@mieliespoor mieliespoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a high level, this looks acceptable. Will need to test it to be more confident.

@@ -0,0 +1,68 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this whitespace?

env.example Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes can be excluded from the PR. This is mainly local dev requirements, so not sure we should include it in the PR?

@mieliespoor
Copy link
Contributor

Can you change the title of the PR from Hello UI to something more relevant to the changes?

@ArkVex
Copy link
Author

ArkVex commented Mar 15, 2025

Can you change the title of the PR from Hello UI to something more relevant to the changes?

Ohhk i will do that

@ArkVex ArkVex changed the title hello ui Add tags on projects Mar 15, 2025
@ArkVex
Copy link
Author

ArkVex commented Mar 20, 2025

@mieliespoor what's the status?

@ArkVex
Copy link
Author

ArkVex commented Mar 23, 2025

helo @mieliespoor @klesh somebody plz review this

// Load associated tags
db.Model(&project).Association("Tags").Find(&project.Tags)

c.JSON(200, project)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
c.JSON(200, project)
c.JSON(http.StatusOK, project)

Should this not also be http.StatusOK instead of the explicit 200? Makes for easier reading.

@mieliespoor
Copy link
Contributor

Added one more comment around readability and consistency. Looks good on a highlevel.

Two things I would say that is missing on this PR:

  1. Some screenshots on how the UI would look after the changes?
  2. Missing unit tests. No unit tests were added or changed as part of this.

Other than that, I would allow the code owners to also review this.

)

// Project represents a DevLake project
type Project struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Project model located in https://github.com/apache/incubator-devlake/blob/main/backend/core/models/project.go

Please following the existing folder convention.

  1. All backend code should be placed in the backend folder.
  2. UI code should go to the config-ui folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][UI] Add tags on projects
3 participants