-
Notifications
You must be signed in to change notification settings - Fork 582
Add tags on projects #8334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tags on projects #8334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a high level, this looks acceptable. Will need to test it to be more confident.
models/project.go
Outdated
@@ -0,0 +1,68 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this whitespace?
env.example
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes can be excluded from the PR. This is mainly local dev requirements, so not sure we should include it in the PR?
Can you change the title of the PR from Hello UI to something more relevant to the changes? |
Ohhk i will do that |
@mieliespoor what's the status? |
helo @mieliespoor @klesh somebody plz review this |
// Load associated tags | ||
db.Model(&project).Association("Tags").Find(&project.Tags) | ||
|
||
c.JSON(200, project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c.JSON(200, project) | |
c.JSON(http.StatusOK, project) |
Should this not also be http.StatusOK instead of the explicit 200? Makes for easier reading.
Added one more comment around readability and consistency. Looks good on a highlevel. Two things I would say that is missing on this PR:
Other than that, I would allow the code owners to also review this. |
) | ||
|
||
// Project represents a DevLake project | ||
type Project struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a Project model located in https://github.com/apache/incubator-devlake/blob/main/backend/core/models/project.go
Please following the existing folder convention.
- All backend code should be placed in the
backend
folder. - UI code should go to the
config-ui
folder
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
This PR introduces a project tagging system, allowing users to assign and manage tags for better organization. It updates the database schema to store tags, enhances the API to support tag-based filtering, and improves the UI for easy tag management. This feature helps tech leads and engineering managers track projects efficiently and create dashboards based on shared tags.
Does this close any open issues?
Closes #8279
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.