Skip to content

Fix/8538 GitHub zero time #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix/8538 GitHub zero time #8583

merged 2 commits into from
Sep 24, 2025

Conversation

petkostas
Copy link
Contributor

@petkostas petkostas commented Sep 22, 2025 •
edited
Loading

Summary

GitHub GraphQL returns zero time (&time.Time{}) for nullable fields, this leads to GORM not properly handling this cases.
This PR:

  • Introduces a new core helper util NilIfZeroTime in order to ensure that *time.Time fields are assigned the nil value.
  • Fixes the relevant cases in both collectors and extractors (as existing entries in the DB should be properly handled as well).

Does this close any open issues?

Closes #8538 #8442

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug labels Sep 22, 2025
@petkostas petkostas mentioned this pull request Sep 22, 2025
Closed
klesh
klesh reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nice work. Thanks for your contribution.

@klesh klesh merged commit 0d753c4 into main Sep 24, 2025
24 checks passed
@klesh klesh deleted the fix/8538-github-zero-time branch September 24, 2025 06:08
@github-actions GitHub Actions
Copy link
Contributor

🤖 The current file has a conflict, and the pr cannot be automatically created.

@github-actions github-actions bot added the bot/auto-cherry-pick-failed auto cherry pick failed label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-failed auto cherry pick failed component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@petkostas @klesh