Skip to content

Commit

Permalink
[GLUTEN-5085] [VL] Fix get_velox.sh on macOS
Browse files Browse the repository at this point in the history
sed's `-i` param is different on macOS than on Linux, we need to use
`-i ''` rather than `-i` to make it work.
  • Loading branch information
xumingming committed Mar 22, 2024
1 parent 4a953a2 commit 17210d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ep/build-velox/src/get_velox.sh
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ function setup_macos {

sed -i '' $'/^ run_and_time install_double_conversion/a\\\n run_and_time install_folly\\\n' scripts/setup-macos.sh
# need set BUILD_SHARED_LIBS flag for thrift
sed -i "/facebook\/fbthrift/{n;s/cmake_install -DBUILD_TESTS=OFF/cmake_install -DBUILD_TESTS=OFF -DBUILD_SHARED_LIBS=OFF/;}" scripts/setup-macos.sh
sed -i '' "/facebook\/fbthrift/{n;s/cmake_install -DBUILD_TESTS=OFF/cmake_install -DBUILD_TESTS=OFF -DBUILD_SHARED_LIBS=OFF/;}" scripts/setup-macos.sh
}

if [ $OS == 'Linux' ]; then
Expand Down

0 comments on commit 17210d9

Please sign in to comment.