[GLUTEN-8476][VL] Fix allocate and free memory (#8477)

fix security volations
apache · Jan 10, 2025 · 4bdda17 · 4bdda17
1 parent cd327f9
commit 4bdda17
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cpp/core/benchmarks/CompressionBenchmark.cc b/cpp/core/benchmarks/CompressionBenchmark.cc
@@ -48,7 +48,9 @@ void printTrace(void) {
   for (i = 0; i < size; i++)
     printf("    %s\n", strings[i]);
   puts("");
-  free(strings);
+  if (strings != nullptr) {
+    free(strings);
+  }
 }
 
 using arrow::RecordBatchReader;

diff --git a/cpp/core/memory/MemoryAllocator.cc b/cpp/core/memory/MemoryAllocator.cc
@@ -157,6 +157,7 @@ bool StdMemoryAllocator::reallocate(void* p, int64_t size, int64_t newSize, void
 }
 
 bool StdMemoryAllocator::reallocateAligned(void* p, uint64_t alignment, int64_t size, int64_t newSize, void** out) {
+  GLUTEN_CHECK(p != nullptr, "reallocate with nullptr");
   if (newSize <= 0) {
     return false;
   }
@@ -179,6 +180,7 @@ bool StdMemoryAllocator::reallocateAligned(void* p, uint64_t alignment, int64_t
 }
 
 bool StdMemoryAllocator::free(void* p, int64_t size) {
+  GLUTEN_CHECK(p != nullptr, "free with nullptr");
   std::free(p);
   bytes_ -= size;
   return true;