address comments

apache · Mar 20, 2024 · eeed575 · eeed575
1 parent 9fb3e36
commit eeed575
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala b/backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala
@@ -133,7 +133,10 @@ class SparkPlanExecApiImpl extends SparkPlanExecApi {
   override def genUuidTransformer(
       substraitExprName: String,
       original: Uuid): ExpressionTransformer = {
-    UuidTransformer(substraitExprName, original)
+    GenericExpressionTransformer(
+      substraitExprName,
+      Seq(LiteralTransformer(Literal(original.randomSeed.get))),
+      original)
   }
 
   /** Transform map_entries to Substrait. */

diff --git a/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala b/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala
@@ -240,18 +240,3 @@ case class GetArrayStructFieldsTransformer(
     ExpressionBuilder.makeScalarFunction(functionId, inputNodes, typeNode)
   }
 }
-
-case class UuidTransformer(substraitExprName: String, original: Uuid)
-  extends ExpressionTransformer {
-
-  override def doTransform(args: java.lang.Object): ExpressionNode = {
-    val functionMap = args.asInstanceOf[java.util.HashMap[String, java.lang.Long]]
-    val functionId = ExpressionBuilder.newScalarFunction(
-      functionMap,
-      ConverterUtils.makeFuncName(substraitExprName, Seq(LongType)))
-    val seed = Literal(original.randomSeed.get)
-    val inputNodes = Lists.newArrayList[ExpressionNode](LiteralTransformer(seed).doTransform(args))
-    val typeNode = ConverterUtils.getTypeNode(original.dataType, original.nullable)
-    ExpressionBuilder.makeScalarFunction(functionId, inputNodes, typeNode)
-  }
-}