Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix assertion failures when mixing use of partial aggregation spilling and flushing #3872

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 29, 2023

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer
Copy link
Member Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3872_time.csv log/native_master_11_28_2023_e0f197fc2_time.csv difference percentage
q1 33.95 33.03 -0.921 97.29%
q2 23.26 24.97 1.709 107.35%
q3 37.85 37.84 -0.018 99.95%
q4 37.80 38.37 0.571 101.51%
q5 72.42 71.84 -0.580 99.20%
q6 7.06 7.08 0.016 100.23%
q7 85.66 83.42 -2.246 97.38%
q8 89.28 86.34 -2.932 96.72%
q9 124.02 124.39 0.370 100.30%
q10 45.70 45.34 -0.361 99.21%
q11 20.28 20.27 -0.001 99.99%
q12 27.14 26.06 -1.086 96.00%
q13 47.73 47.23 -0.497 98.96%
q14 14.28 13.83 -0.447 96.87%
q15 27.84 29.53 1.687 106.06%
q16 15.31 15.40 0.087 100.57%
q17 103.04 102.38 -0.669 99.35%
q18 147.96 150.59 2.627 101.78%
q19 12.86 13.04 0.187 101.46%
q20 30.10 27.68 -2.424 91.95%
q21 226.81 223.37 -3.444 98.48%
q22 13.05 14.21 1.160 108.89%
total 1243.42 1236.20 -7.214 99.42%

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zhztheplayer zhztheplayer merged commit b7af832 into apache:main Nov 29, 2023
6 of 15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3872_time.csv log/native_master_11_28_2023_e0f197fc2_time.csv difference percentage
q1 33.62 33.03 -0.590 98.25%
q2 25.12 24.97 -0.153 99.39%
q3 37.96 37.84 -0.127 99.67%
q4 37.76 38.37 0.604 101.60%
q5 71.60 71.84 0.246 100.34%
q6 5.38 7.08 1.700 131.61%
q7 83.55 83.42 -0.136 99.84%
q8 86.43 86.34 -0.091 99.89%
q9 126.54 124.39 -2.143 98.31%
q10 45.83 45.34 -0.491 98.93%
q11 20.66 20.27 -0.384 98.14%
q12 25.37 26.06 0.691 102.72%
q13 47.56 47.23 -0.328 99.31%
q14 14.79 13.83 -0.960 93.51%
q15 28.90 29.53 0.630 102.18%
q16 15.62 15.40 -0.219 98.60%
q17 101.56 102.38 0.818 100.81%
q18 149.19 150.59 1.395 100.93%
q19 14.56 13.04 -1.515 89.59%
q20 28.62 27.68 -0.943 96.71%
q21 226.08 223.37 -2.707 98.80%
q22 14.53 14.21 -0.314 97.84%
total 1241.22 1236.20 -5.018 99.60%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants