-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3378][CORE] DeltaScanTransformer to support delta table #3982
Conversation
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
|
||
def createDataSourceTransformer( | ||
batchScan: FileSourceScanExec, | ||
partitionFilters: Seq[Expression]): FileSourceScanExecTransformer = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename partitionFilters
to newPartitionFilters
so that avoid confusion as FileSourceScanExec
also includes this kind of member?
By the way, is it reasonable to move previous column mapping overrides into |
They are two things.
to remove all the codes related to specified lake format in gluten-core. |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
@YannByron are you planning to add protocol reader version check? |
What changes were proposed in this pull request?
Based on the new framework defined in #3843, modify the implementation of delta scan.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)