-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Support regexp_replace function with position argument #4411
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
8ac6206
to
9efbcb8
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Could you update the PR description? Thanks! |
1a383b9
to
da1c396
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
3e61da3
to
22288c5
Compare
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@PHILO-HE Sorry, I just synced with @codyschierbeck. regexp_replace in Velox isn't ready yet. Let's wait until his PR is merged |
Let's wait for upstream velox pr facebookincubator/velox#8333. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Run Gluten Clickhouse CI |
ad4c9f8
to
1b8e47a
Compare
Run Gluten Clickhouse CI |
1b8e47a
to
cca720c
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
c513c42
to
525eb54
Compare
Run Gluten Clickhouse CI |
As facebookincubator/velox#8387 has been merged, we can land this pr. @marin-ma, do you have any other comment? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
In the main code, gluten will make regexp_replace fall back if its last
pos
arg is specified by user with a non-default value. We note upstream velox has a fix for this function. So we are removing such fallback for velox backend.This PR depends on a velox PR which fixes newly found issues: facebookincubator/velox#8387
How was this patch tested?
Existing spark UTs.