Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4989][CH] Support function timestamp_add #5012

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Conversation

loneylee
Copy link
Member

What changes were proposed in this pull request?

(Fixes: #4989)

How was this patch tested?

Test by ut

Copy link

#4989

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binmahone
Copy link
Contributor

LGTM

@binmahone binmahone merged commit e1f0c01 into apache:main Mar 20, 2024
20 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_03_20_2024_time.csv log/native_master_03_19_2024_e977d79e3_time.csv difference percentage
q1 38.53 36.21 -2.311 94.00%
q2 24.00 24.11 0.109 100.46%
q3 37.50 36.64 -0.854 97.72%
q4 38.61 38.02 -0.590 98.47%
q5 71.63 69.07 -2.563 96.42%
q6 7.37 5.91 -1.459 80.19%
q7 83.96 82.31 -1.651 98.03%
q8 84.46 85.26 0.803 100.95%
q9 125.15 121.93 -3.219 97.43%
q10 45.58 45.61 0.027 100.06%
q11 20.52 20.57 0.048 100.23%
q12 28.80 28.32 -0.482 98.33%
q13 48.70 47.17 -1.533 96.85%
q14 22.25 16.86 -5.393 75.76%
q15 31.14 31.19 0.052 100.17%
q16 15.42 16.26 0.846 105.48%
q17 102.47 99.14 -3.327 96.75%
q18 143.60 142.77 -0.829 99.42%
q19 13.64 14.68 1.044 107.65%
q20 27.02 28.29 1.265 104.68%
q21 225.52 227.96 2.443 101.08%
q22 13.96 14.00 0.041 100.29%
total 1249.81 1232.28 -17.534 98.60%

@loneylee loneylee deleted the 4989 branch March 21, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Support timestampadd on CH backend
4 participants