[CH] Issue 5018 #5019
Merged
[CH] Issue 5018 #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
This PR is is blocked by #4676, needs its bug fix |
binmahone
commented
Mar 19, 2024
| primaryKeyOption, | ||
| partitionColumns, | ||
| ConverterUtils.convertNamedStructJson(tableSchema), | ||
| clickhouseTableConfigs, | ||
| dataSchema | ||
| tableSchema.toAttributes // use table schema instead of data schema |
There was a problem hiding this comment.
@zzcclp , pay attention to this
There was a problem hiding this comment.
does it make sure that the dataSchema is the same as the tableSchema, especially the nullable property?
If yes, can remove the dataSchema parameter.
basically works, dealing with nullable nullable/not-null ok remove unneceesary change fix compile
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zzcclp
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #5018)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)