Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Update clang-format version to v4.11.0 for Velox backend #5035

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[VL] Update clang-format version to v4.11.0 for Velox backend #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c049a
update clang-format version to v4.11.0 for Velox backend
yma11 Mar 20, 2024
e1d752a
fix format check failures
yma11 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code_style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Run clang-format style check for C/C++ programs.
uses: jidicula/clang-format-action@v3.5.1
uses: jidicula/clang-format-action@v4.11.0
with:
clang-format-version: '12'
clang-format-version: '15'
check-path: ${{ matrix.path['check'] }}
fallback-style: 'Google' # optional

Expand Down
3 changes: 2 additions & 1 deletion cpp/velox/substrait/SubstraitToVeloxExpr.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,8 @@ VectorPtr SubstraitVeloxExprConverter::literalsToVector(
case ::substrait::Expression_Literal::LiteralTypeCase::kNull: {
auto veloxType = SubstraitParser::parseType(childLiteral.null());
auto kind = veloxType->kind();
return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL(constructFlatVector, kind, elementAtFunc, childSize, veloxType, pool_);
return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL(
constructFlatVector, kind, elementAtFunc, childSize, veloxType, pool_);
}
case ::substrait::Expression_Literal::LiteralTypeCase::kIntervalDayToSecond:
return constructFlatVector<TypeKind::BIGINT>(elementAtFunc, childSize, INTERVAL_DAY_TIME(), pool_);
Expand Down
Loading