Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Daily Update Velox Version (2024_03_22) #5077

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

GlutenPerfBot
Copy link
Contributor

Upstream Velox's New Commits:

79df29c3b by Jialiang Tan, Enable arbitrator in OperatorTestBase by default (9141)
dc561a358 by rexan, Handle ShortDecimal correctly inside `importFromArrow` (8957)
ffce11b15 by Mahadevuni Naveen Kumar, Add test for ParquetReaderBenchmark (8726)
1f4ce8c0c by Masha Basmanova, Extract SimpleFunctionApi.h from Type.h (9182)
c4d3f6f54 by youxiduo, Fix lead/lag for zero offset (9026)
9b4a210c0 by Pedro Pedreira, Upgrade folly to v2024.02.26.00 (from v2023.12.04.00) (8950)
0e65b22be by Masha Basmanova, Back out "Deshim //folly:dynamic to //folly/json:dynamic in velox" (9197)
94f52ecb8 by Ma, Rong, Fix read parquet for different encodings across row groups (9129)
86f12b756 by yuling.sh, Add order-sensitive metadata for aggregate functions (9050)
5ada3043e by mwish, Remove legacy codegen code (9176)
49d22aba7 by xiaoxmeng, Fix findPeerOperators in group execution mode (9188)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PHILO-HE
Copy link
Contributor

Hi @ulysses-you, I note you have one PR merged to Velox. Should the below gluten code be removed? If yes, please help do that in a separate PR. Thanks!

// This is a workaround for Velox backend, because velox has bug if the

@PHILO-HE PHILO-HE merged commit 6ea2c4e into apache:main Mar 22, 2024
15 of 18 checks passed
@ulysses-you
Copy link
Contributor

@PHILO-HE thank you for the reminder, I will send a pr later

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5077_time.csv log/native_master_03_21_2024_9d859d8e4_time.csv difference percentage
q1 37.14 36.78 -0.358 99.04%
q2 23.74 23.82 0.073 100.31%
q3 37.08 36.97 -0.104 99.72%
q4 38.06 38.29 0.229 100.60%
q5 70.86 68.82 -2.034 97.13%
q6 8.85 7.79 -1.050 88.12%
q7 82.88 82.16 -0.714 99.14%
q8 87.96 85.93 -2.032 97.69%
q9 120.52 120.31 -0.217 99.82%
q10 45.35 43.15 -2.191 95.17%
q11 20.25 20.44 0.191 100.94%
q12 30.48 26.75 -3.736 87.74%
q13 47.12 48.78 1.660 103.52%
q14 17.08 21.16 4.084 123.91%
q15 30.40 28.73 -1.673 94.50%
q16 14.16 14.42 0.257 101.81%
q17 100.74 99.19 -1.558 98.45%
q18 145.55 139.46 -6.091 95.82%
q19 16.57 15.07 -1.504 90.92%
q20 26.75 27.86 1.113 104.16%
q21 226.09 226.99 0.898 100.40%
q22 13.78 14.13 0.345 102.50%
total 1241.41 1226.99 -14.412 98.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants