-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-8020][VL] Remove the libhdfs3 installation script required for static linking #8013
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@JkSelf, can we also remove |
@JkSelf could you please help to link with the right Issue? |
Seems we still need it for deciding whether to register hdfs filesystem. |
Yes. We also need to pass the enable_hdfs to velox compile scripts. |
@JkSelf is document updated? |
The changes is helpful for #7977 , libhdfs3 compile issue found during the test. I will bypass the libhdfs3. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
2e3a920
to
b1419f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any tests covering build_libhdfs3.sh
?
@zhztheplayer Test this script locally. |
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
How was this patch tested?
Existing compile scripts.