Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8375][CH][MINOR] Fix USE_EMBEDDED_COMPILER #8441

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

baibaichen
Copy link
Contributor

What changes were proposed in this pull request?

#8378 doesn't #include "config.h", causing USE_EMBEDDED_COMPILER failed, let's fix it.

(Fixes: #8375)

How was this patch tested?

TEST ARM and x86

Copy link

github-actions bot commented Jan 7, 2025

#8375

Copy link

github-actions bot commented Jan 7, 2025

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@taiyang-li taiyang-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgbo-ustc
Copy link
Contributor

LGTM

@baibaichen
Copy link
Contributor Author

Run Gluten Clickhouse CI on ARM

@baibaichen baibaichen merged commit 198b1cc into apache:main Jan 7, 2025
8 checks passed
@baibaichen baibaichen deleted the feature/hot-fix branch January 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] It's not allowed to have so large translation units
3 participants