Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][C++] Support building GraphAr with system installed arrow #230

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 28, 2023

Proposed changes

This change enable the feature that GraphAr can build with the system installed arrow, linking them as static library.

  • Add a cmake option BUILD_ARROW_FROM_SOURCE to configure wether to build arrow from source (default OFF)

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: acezen <[email protected]>

Update

Update

Fix

update

Update

update

Update
@acezen acezen force-pushed the build-with-system-installed-arrow branch from 2c91caa to ad1a55e Compare August 29, 2023 02:30
@acezen acezen changed the title [Dev][C++] Support build GraphAr with system installed arrow [Feat][C++] Support build GraphAr with system installed arrow Aug 29, 2023
@acezen acezen changed the title [Feat][C++] Support build GraphAr with system installed arrow [Feat][C++] Support building GraphAr with system installed arrow Aug 29, 2023
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Thanks for this change!

cpp/README.md Outdated Show resolved Hide resolved
@acezen acezen removed the request for review from sighingnow August 29, 2023 09:44
@acezen acezen merged commit dacd613 into apache:main Aug 29, 2023
4 checks passed
@acezen acezen deleted the build-with-system-installed-arrow branch August 29, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants