Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devinfra): Add test coverage to CI to measure the covering code of unitest (Spark) #589

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Elssky
Copy link
Contributor

@Elssky Elssky commented Aug 13, 2024

Reason for this PR

solution to #189, extension of #580

What changes are included in this PR?

Add Spark test coverage to CI to measure the covering code of unitest### Are these changes tested?

Are there any user-facing changes?

no

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@SemyonSinchenko
Copy link
Member

SemyonSinchenko commented Aug 13, 2024

May we extend it to PySpark too? The coverage is already computed during the CI but it doesn't published. I see, that the Codecov tool has a support of pytest that is used for PySpark.

The entry point of PySpark tests is the Makefile:
https://github.com/apache/incubator-graphar/blob/main/pyspark/Makefile#L35

@Elssky
Copy link
Contributor Author

Elssky commented Aug 13, 2024

May we extend it to PySpark too? The coverage is already computed during the CI but it doesn't published. I see, that the Codecov tool has a support of pytest that is used for PySpark.

The entry point of PySpark tests is the Makefile: https://github.com/apache/incubator-graphar/blob/main/pyspark/Makefile#L35

Sure, I'll keep track of this task👌

@acezen acezen changed the title [Feat][DevInfra] Add test coverage to CI to measure the covering code of unitest (Spark) feat(devinfra): Add test coverage to CI to measure the covering code of unitest (Spark) Aug 16, 2024
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit b7f54ee into apache:main Aug 16, 2024
6 checks passed
acezen pushed a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
@Elssky Elssky deleted the spark branch October 30, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants