-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(format):change the naming of vertex/edge unique identify type from label
to type
#605
Conversation
hi, @Elssky, you should update the testing submodule to the latest commit |
|
01a7117
to
d385fd1
Compare
Signed-off-by: acezen <[email protected]>
Signed-off-by: acezen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=============================================
- Coverage 95.11% 74.28% -20.84%
- Complexity 0 226 +226
=============================================
Files 8 29 +21
Lines 737 2749 +2012
Branches 0 179 +179
=============================================
+ Hits 701 2042 +1341
- Misses 36 551 +515
- Partials 0 156 +156 ☔ View full report in Codecov by Sentry. |
Signed-off-by: acezen <[email protected]>
label
to type
label
to type
label
to type
Signed-off-by: acezen <[email protected]>
Signed-off-by: acezen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rom `label` to `type` (apache#605) --------- Signed-off-by: Elssky <[email protected]> Co-authored-by: acezen <[email protected]>
…rom `label` to `type` (apache#605) --------- Signed-off-by: Elssky <[email protected]> Co-authored-by: acezen <[email protected]>
…rom `label` to `type` (apache#605) --------- Signed-off-by: Elssky <[email protected]> Co-authored-by: acezen <[email protected]>
Reason for this PR
#604
What changes are included in this PR?
Change the naming of vertex/edge type from
label
totype
Are these changes tested?
yes, and changed testing apache/incubator-graphar-testing#23
Are there any user-facing changes?
yes
BREAKING CHANGE:
label
totype
.label
of C++/Spark/PySpark library change totype
, likegetLabel
togetType
.