Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(format):change the naming of vertex/edge unique identify type from label to type #605

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

Elssky
Copy link
Contributor

@Elssky Elssky commented Aug 26, 2024

Reason for this PR

#604

What changes are included in this PR?

Change the naming of vertex/edge type from label to type

Are these changes tested?

yes, and changed testing apache/incubator-graphar-testing#23

Are there any user-facing changes?

yes

BREAKING CHANGE:

  • the vertex info and edge info configuration need to update label to type.
  • Some APIs related to label of C++/Spark/PySpark library change to type, like getLabel to getType.

@acezen
Copy link
Contributor

acezen commented Aug 26, 2024

hi, @Elssky, you should update the testing submodule to the latest commit

@Elssky
Copy link
Contributor Author

Elssky commented Aug 26, 2024

hi, @Elssky, you should update the testing submodule to the latest commit
yes

@acezen acezen self-requested a review August 27, 2024 02:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 25 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (359b829) to head (ecb1d4b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ala/org/apache/graphar/example/GraphAr2Neo4j.scala 0.00% 11 Missing ⚠️
...la/org/apache/graphar/example/GraphAr2Nebula.scala 0.00% 4 Missing ⚠️
...la/org/apache/graphar/graph/GraphTransformer.scala 55.55% 2 Missing and 2 partials ⚠️
...n/scala/org/apache/graphar/graph/GraphWriter.scala 85.71% 1 Missing and 2 partials ⚠️
...r/src/main/scala/org/apache/graphar/EdgeInfo.scala 87.50% 0 Missing and 1 partial ⚠️
.../src/main/scala/org/apache/graphar/GraphInfo.scala 66.66% 1 Missing ⚠️
...src/main/scala/org/apache/graphar/VertexInfo.scala 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #605       +/-   ##
=============================================
- Coverage     95.11%   74.28%   -20.84%     
- Complexity        0      226      +226     
=============================================
  Files             8       29       +21     
  Lines           737     2749     +2012     
  Branches          0      179      +179     
=============================================
+ Hits            701     2042     +1341     
- Misses           36      551      +515     
- Partials          0      156      +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acezen acezen changed the title feat(format):rename 'label' as 'type' feat!(format):change the naming of vertex/edge type from label to type Aug 27, 2024
@acezen acezen changed the title feat!(format):change the naming of vertex/edge type from label to type feat!(format):change the naming of vertex/edge unique identify type from label to type Aug 27, 2024
Signed-off-by: acezen <[email protected]>
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit bbd562e into apache:main Aug 27, 2024
9 checks passed
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
…rom `label` to `type` (apache#605)

---------

Signed-off-by: Elssky <[email protected]>
Co-authored-by: acezen <[email protected]>
@Elssky Elssky mentioned this pull request Sep 18, 2024
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
…rom `label` to `type` (apache#605)



---------

Signed-off-by: Elssky <[email protected]>
Co-authored-by: acezen <[email protected]>
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
…rom `label` to `type` (apache#605)



---------

Signed-off-by: Elssky <[email protected]>
Co-authored-by: acezen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants