This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 598
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Unit tests for HdfsUploader (#603)
1. Refactor HdfsUploader 2. Add Unit tests for HdfsUploader
- Loading branch information
Showing
4 changed files
with
136 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
heron/uploaders/tests/java/com/twitter/heron/uploader/hdfs/HdfsUploaderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright 2016 Twitter. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.twitter.heron.uploader.hdfs; | ||
|
|
||
| import org.junit.After; | ||
| import org.junit.Assert; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| import com.twitter.heron.spi.common.Config; | ||
|
|
||
| public class HdfsUploaderTest { | ||
| private HdfsUploader uploader; | ||
| private HdfsController controller; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| Config config = Mockito.mock(Config.class); | ||
|
|
||
| // Insert mock HdfsController | ||
| uploader = Mockito.spy(new HdfsUploader()); | ||
| controller = Mockito.mock(HdfsController.class); | ||
| Mockito.doReturn(controller).when(uploader).getHdfsController(); | ||
|
|
||
| uploader.initialize(config); | ||
| } | ||
|
|
||
| @After | ||
| public void after() throws Exception { | ||
| } | ||
|
|
||
| @Test | ||
| public void testUploadPackage() throws Exception { | ||
| // Local file not exist | ||
| Mockito.doReturn(false).when(uploader).isLocalFileExists(Mockito.anyString()); | ||
| Assert.assertNull(uploader.uploadPackage()); | ||
| Mockito.verify(controller, Mockito.never()).copyFromLocalFile( | ||
| Mockito.anyString(), Mockito.anyString()); | ||
|
|
||
| // Failed to create folder on hdfs | ||
| Mockito.doReturn(true).when(uploader).isLocalFileExists(Mockito.anyString()); | ||
| Mockito.doReturn(false).when(controller).exists(Mockito.anyString()); | ||
| Mockito.doReturn(false).when(controller).mkdirs(Mockito.anyString()); | ||
| Assert.assertNull(uploader.uploadPackage()); | ||
| Mockito.verify(controller, Mockito.never()).copyFromLocalFile( | ||
| Mockito.anyString(), Mockito.anyString()); | ||
|
|
||
| // Failed to copy file from local to hdfs | ||
| Mockito.doReturn(true).when(controller).mkdirs(Mockito.anyString()); | ||
| Mockito.doReturn(false).when(controller).copyFromLocalFile( | ||
| Mockito.anyString(), Mockito.anyString()); | ||
| Assert.assertNull(uploader.uploadPackage()); | ||
| Mockito.verify(controller).copyFromLocalFile(Mockito.anyString(), Mockito.anyString()); | ||
|
|
||
| // Happy path | ||
| Mockito.doReturn(true).when(controller).copyFromLocalFile( | ||
| Mockito.anyString(), Mockito.anyString()); | ||
| Assert.assertNotNull(uploader.uploadPackage()); | ||
| Mockito.verify(controller, Mockito.atLeastOnce()).copyFromLocalFile( | ||
| Mockito.anyString(), Mockito.anyString()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testUndo() throws Exception { | ||
| Mockito.doReturn(false).when(controller).delete(Mockito.anyString()); | ||
| Assert.assertFalse(uploader.undo()); | ||
| Mockito.verify(controller).delete(Mockito.anyString()); | ||
|
|
||
| Mockito.doReturn(true).when(controller).delete(Mockito.anyString()); | ||
| Assert.assertTrue(uploader.undo()); | ||
| } | ||
| } |