[incubator-kie-issues#1344] Rrefactoring/reorganizing Functions

apache · Jun 27, 2024 · 12ae119 · 12ae119
1 parent 865712e
commit 12ae119
Show file tree

Hide file tree

Showing 36 changed files with 1,128 additions and 1,473 deletions.
diff --git a/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/FEEL.java b/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/FEEL.java
@@ -148,7 +148,7 @@ static FEEL newInstance(ClassLoader cl, List<FEELProfile> profiles) {
      * Evaluates the given compiled FEEL expression using the
      * given EvaluationContext, and returns the result
      *
-     * @param expression a FEEL expression
+     * @param expr a FEEL expression
      * @param ctx the EvaluationContext to be used for defining
      *            input variables and additional feel event listeners
      *            contextual to this method call

diff --git a/...-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/visitor/ASTTemporalConstantVisitor.java b/...-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/visitor/ASTTemporalConstantVisitor.java
@@ -70,8 +70,7 @@ public class ASTTemporalConstantVisitor extends DefaultedVisitor<ASTNode> {
                                                                          DateAndTimeFunction.INSTANCE,
                                                                          DurationFunction.INSTANCE,
                                                                          org.kie.dmn.feel.runtime.functions.extended.TimeFunction.INSTANCE,
-                                                                         org.kie.dmn.feel.runtime.functions.extended.DateFunction.INSTANCE,
-                                                                         org.kie.dmn.feel.runtime.functions.extended.DurationFunction.INSTANCE);
+                                                                         org.kie.dmn.feel.runtime.functions.extended.DateFunction.INSTANCE);
     public static final Set<String> TEMPORAL_FNS_NAMES = TEMPORAL_FNS.stream().map(FEELFunction::getName).collect(Collectors.toSet());
 
     public ASTTemporalConstantVisitor(CompilerContext ctx) {
@@ -200,10 +199,6 @@ private TemporalConstantNode buildTCNodeForDuration(FunctionInvocationNode n, FE
                 FEELFnResult<TemporalAmount> invoke = DurationFunction.INSTANCE.invoke(p0);
                 return invoke.cata(e -> null,
                                    v -> new TemporalConstantNode(n, v, DurationFunction.INSTANCE, Collections.singletonList(p0)));
-            } else if (fn == org.kie.dmn.feel.runtime.functions.extended.DurationFunction.INSTANCE) {
-                FEELFnResult<TemporalAmount> invoke = org.kie.dmn.feel.runtime.functions.extended.DurationFunction.INSTANCE.invoke(p0);
-                return invoke.cata(e -> null,
-                                   v -> new TemporalConstantNode(n, v, org.kie.dmn.feel.runtime.functions.extended.DurationFunction.INSTANCE, Collections.singletonList(p0)));
             }
         }
         return null;

diff --git a/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/Range.java b/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/Range.java
@@ -20,7 +20,7 @@
 
 public interface Range {
 
-    static enum RangeBoundary {
+    enum RangeBoundary {
         OPEN, CLOSED;
     }
 

diff --git a/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BuiltInFunctions.java b/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BuiltInFunctions.java
@@ -119,7 +119,20 @@ public class BuiltInFunctions {
             OverlapsAfterFunction.INSTANCE,
             MeetsFunction.INSTANCE,
             MetByFunction.INSTANCE,
-            ListReplaceFunction.INSTANCE
+            ListReplaceFunction.INSTANCE,
+            StringJoinFunction.INSTANCE,
+
+            NowFunction.INSTANCE,
+            TodayFunction.INSTANCE,
+            ContextPutFunction.INSTANCE,
+            ContextMergeFunction.INSTANCE,
+            ContextFunction.INSTANCE,
+            RoundUpFunction.INSTANCE,
+            RoundDownFunction.INSTANCE,
+            RoundHalfUpFunction.INSTANCE,
+            RoundHalfDownFunction.INSTANCE,
+
+            RangeFunction.INSTANCE,
     };
 
     public static FEELFunction[] getFunctions() {

diff --git a/...e/functions/extended/ContextFunction.java → ...el/runtime/functions/ContextFunction.java b/...e/functions/extended/ContextFunction.java → ...el/runtime/functions/ContextFunction.java
@@ -16,17 +16,14 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * Proposal DMN14-187

diff --git a/...ctions/extended/ContextMergeFunction.java → ...ntime/functions/ContextMergeFunction.java b/...ctions/extended/ContextMergeFunction.java → ...ntime/functions/ContextMergeFunction.java
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.util.Collections;
 import java.util.HashMap;
@@ -25,9 +25,6 @@
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * Proposal DMN14-187

diff --git a/...unctions/extended/ContextPutFunction.java → ...runtime/functions/ContextPutFunction.java b/...unctions/extended/ContextPutFunction.java → ...runtime/functions/ContextPutFunction.java
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.util.HashMap;
 import java.util.List;
@@ -27,9 +27,6 @@
 import org.kie.dmn.feel.lang.types.BuiltInType;
 import org.kie.dmn.feel.lang.types.impl.ImmutableFPAWrappingPOJO;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * Proposal DMN14-187

diff --git a/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DateFunction.java b/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DateFunction.java
@@ -66,10 +66,15 @@ public FEELFnResult<TemporalAccessor> invoke(@ParameterName( "from" ) String val
         try {
             return FEELFnResult.ofResult(LocalDate.from(FEEL_DATE.parse(val)));
         } catch (DateTimeException e) {
-            return FEELFnResult.ofError(new InvalidParametersEvent(Severity.ERROR, "date", e));
+            return manageDateTimeException(e, val);
         }
     }
 
+    public FEELFnResult<TemporalAccessor> manageDateTimeException(DateTimeException e, String val) {
+        return FEELFnResult.ofError(new InvalidParametersEvent(Severity.ERROR, "date", e));
+    }
+
+
     public FEELFnResult<TemporalAccessor> invoke(@ParameterName( "year" ) Number year, @ParameterName( "month" ) Number month, @ParameterName( "day" ) Number day) {
         if ( year == null ) {
             return FEELFnResult.ofError(new InvalidParametersEvent(Severity.ERROR, "year", "cannot be null"));

diff --git a/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DurationFunction.java b/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DurationFunction.java
@@ -42,10 +42,6 @@ public FEELFnResult<TemporalAmount> invoke(@ParameterName( "from" ) String val)
             return FEELFnResult.ofError(new InvalidParametersEvent(Severity.ERROR, "from", "cannot be null"));
         }
 
-        if ( val.indexOf("-") > 0) {
-            return FEELFnResult.ofError( new InvalidParametersEvent(Severity.ERROR, "from", "negative values for units are not allowed.") );
-        }
-
         try {
             // try to parse as days/hours/minute/seconds
             return FEELFnResult.ofResult( Duration.parse( val ) );

diff --git a/...dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/GetEntriesFunction.java b/...dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/GetEntriesFunction.java
@@ -25,7 +25,6 @@
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.extended.ContextPutFunction;
 
 public class GetEntriesFunction extends BaseFEELFunction {
 

diff --git a/...ntime/functions/extended/NowFunction.java → ...n/feel/runtime/functions/NowFunction.java b/...ntime/functions/extended/NowFunction.java → ...n/feel/runtime/functions/NowFunction.java
@@ -16,17 +16,16 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.time.ZonedDateTime;
 import java.time.temporal.TemporalAccessor;
 
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-
 public class NowFunction
         extends BaseFEELFunction {
 
+    public static final NowFunction INSTANCE = new NowFunction();
+
     public NowFunction() {
         super( "now" );
     }

diff --git a/...ime/functions/extended/RangeFunction.java → ...feel/runtime/functions/RangeFunction.java b/...ime/functions/extended/RangeFunction.java → ...feel/runtime/functions/RangeFunction.java
@@ -16,13 +16,32 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
+
+import java.time.Duration;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.time.ZonedDateTime;
+import java.time.chrono.ChronoPeriod;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+import java.util.function.Predicate;
 
 import org.antlr.v4.runtime.tree.ParseTree;
 import org.kie.dmn.api.feel.runtime.events.FEELEvent;
 import org.kie.dmn.feel.lang.EvaluationContext;
 import org.kie.dmn.feel.lang.FEELDialect;
-import org.kie.dmn.feel.lang.ast.*;
+import org.kie.dmn.feel.lang.ast.AtLiteralNode;
+import org.kie.dmn.feel.lang.ast.BaseNode;
+import org.kie.dmn.feel.lang.ast.FunctionInvocationNode;
+import org.kie.dmn.feel.lang.ast.NullNode;
+import org.kie.dmn.feel.lang.ast.NumberNode;
+import org.kie.dmn.feel.lang.ast.StringNode;
 import org.kie.dmn.feel.lang.impl.EvaluationContextImpl;
 import org.kie.dmn.feel.lang.impl.FEELEventListenersManager;
 import org.kie.dmn.feel.parser.feel11.ASTBuilderVisitor;
@@ -31,24 +50,14 @@
 import org.kie.dmn.feel.runtime.Range;
 import org.kie.dmn.feel.runtime.Range.RangeBoundary;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 import org.kie.dmn.feel.runtime.impl.RangeImpl;
 
-import java.time.*;
-import java.time.chrono.ChronoPeriod;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
-import java.util.Objects;
-import java.util.function.Predicate;
-
 public class RangeFunction extends BaseFEELFunction {
 
     public static final RangeFunction INSTANCE = new RangeFunction();
-    // Defaulting FEELDialect to FEEL
-    private static final EvaluationContext STUBBED = new EvaluationContextImpl(Thread.currentThread().getContextClassLoader(), new FEELEventListenersManager(), 0, FEELDialect.FEEL);
+
+    private static EvaluationContext STUBBED;
+
 
     private static final List<Predicate<BaseNode>> ALLOWED_NODES = Arrays.asList(baseNode -> baseNode instanceof NullNode,
             baseNode -> baseNode instanceof NumberNode,
@@ -111,12 +120,12 @@ public FEELFnResult<Range> invoke(@ParameterName("from") String from) {
         if (!nodeIsAllowed(rightNode)) {
             return FEELFnResult.ofError(new InvalidParametersEvent(FEELEvent.Severity.ERROR, "from", "right endpoint is not a recognised valid literal"));
         }
-        Object left = leftNode.evaluate(STUBBED);
+        Object left = leftNode.evaluate(getStubbed());
         if (!nodeValueIsAllowed(left)) {
             return FEELFnResult.ofError(new InvalidParametersEvent(FEELEvent.Severity.ERROR, "from", "left endpoint is not a valid value " + left.getClass()));
         }
 
-        Object right = rightNode.evaluate(STUBBED);
+        Object right = rightNode.evaluate(getStubbed());
         if (!nodeValueIsAllowed(right)) {
             return FEELFnResult.ofError(new InvalidParametersEvent(FEELEvent.Severity.ERROR, "from", "right endpoint is not a valid value " + right.getClass()));
         }
@@ -169,4 +178,13 @@ protected BaseNode parseNotEmptyInput(String input) {
         return expr;
     }
 
+    private EvaluationContext getStubbed() {
+        if (STUBBED == null) {
+            // Defaulting FEELDialect to FEEL
+            STUBBED = new EvaluationContextImpl(Thread.currentThread().getContextClassLoader(),
+                                                new FEELEventListenersManager(), 0, FEELDialect.FEEL);
+        }
+        return STUBBED;
+    }
+
 }
diff --git a/...functions/extended/RoundDownFunction.java → .../runtime/functions/RoundDownFunction.java b/...functions/extended/RoundDownFunction.java → .../runtime/functions/RoundDownFunction.java
@@ -16,16 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * provisional access for DMN14-126

diff --git a/...tions/extended/RoundHalfDownFunction.java → ...time/functions/RoundHalfDownFunction.java b/...tions/extended/RoundHalfDownFunction.java → ...time/functions/RoundHalfDownFunction.java
@@ -16,16 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * provisional access for DMN14-126

diff --git a/...nctions/extended/RoundHalfUpFunction.java → ...untime/functions/RoundHalfUpFunction.java b/...nctions/extended/RoundHalfUpFunction.java → ...untime/functions/RoundHalfUpFunction.java
@@ -16,16 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * provisional access for DMN14-126

diff --git a/...e/functions/extended/RoundUpFunction.java → ...el/runtime/functions/RoundUpFunction.java b/...e/functions/extended/RoundUpFunction.java → ...el/runtime/functions/RoundUpFunction.java
@@ -16,16 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 /**
  * provisional access for DMN14-126

diff --git a/...unctions/extended/StringJoinFunction.java → ...runtime/functions/StringJoinFunction.java b/...unctions/extended/StringJoinFunction.java → ...runtime/functions/StringJoinFunction.java
@@ -16,16 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.kie.dmn.feel.runtime.functions.extended;
+package org.kie.dmn.feel.runtime.functions;
 
 import java.util.List;
 import java.util.StringJoiner;
 
 import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity;
 import org.kie.dmn.feel.runtime.events.InvalidParametersEvent;
-import org.kie.dmn.feel.runtime.functions.BaseFEELFunction;
-import org.kie.dmn.feel.runtime.functions.FEELFnResult;
-import org.kie.dmn.feel.runtime.functions.ParameterName;
 
 public class StringJoinFunction extends BaseFEELFunction {