Skip to content

Commit

Permalink
allow snapshot for downstream drools-ansible CI to avoid unnecessary …
Browse files Browse the repository at this point in the history 
…CI failures (#5464)
  • Loading branch information
@tkobayas
tkobayas committed Aug 16, 2023
1 parent 2219bf3 commit fe73ad5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/pr-drools-ansible.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
java-version: ${{ matrix.java-version }}
maven-version: ${{ matrix.maven-version }}
cache-key-prefix: ${{ runner.os }}-${{ matrix.java-version }}-maven${{ matrix.maven-version }}
allow-snapshots: true
- name: Build Chain
uses: kiegroup/kie-ci/.ci/actions/build-chain@main
with:
Expand Down

4 comments on commit fe73ad5

@radtriste
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkobayas why was that setup ?
I mean all snapshot artifacts should be built and not downloaded ...

@tkobayas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @radtriste , Thank you for taking a look.

I had raised the PR (https://github.com/kiegroup/drools/pull/5464) in order to avoid CI failures where drools-ansible-rulebook-integration specifies a hard-coded SNAPSHOT version (https://github.com/kiegroup/drools-ansible-rulebook-integration/blob/main/pom.xml#L33) and Drools repo bumps its version.

For example, while drools-ansible-rulebook-integration specifies <version.drools>8.43.0-SNAPSHOT</version.drools>, drools main branch version is bumped to 8.44.0-SNAPSHOT. Then pr-drools-ansible.yml CI fails because it cannot download drools 8.43.0-SNAPSHOT. So we have to manually update the drools-ansible-rulebook-integration/pom.xml. It happens every time drools version is bumped.

I mean all snapshot artifacts should be built and not downloaded ...

Once drools-ansible-rulebook-integration/pom.xml is updated to <version.drools>8.44.0-SNAPSHOT</version.drools>, yes, 8.44.0-SNAPSHOT could be downloaded. But, the SNAPSHOT artifacts are also built and installed into the CI local repo, so aren't the newly built artifacts actually used?

I tested if the pr-drools-ansible.yml CI can pick up the new commit in drools repo. Both projects are 8.44.0-SNAPSHOT and allow-snapshots: true.

https://github.com/kiegroup/drools/pull/5473
kiegroup/drools-ansible-rulebook-integration#74

The pr-drools-ansible.yml CI picks up the newly built artifacts which contains the new method in the drools PR commit (if not, it should fail with a compilation error). However, I'm not 100% confident if I'm doing a right thing. Please kindly share your thoughts on this. Thanks!

@radtriste
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ... drools-ansible-rulebook-integration is not part of the automation on cut-off and that is maybe the problem. we should think about that. In the meantime, this is indeed a workaround, even if I am not a big fan of it, because it could hide some module deps issues ...

@tkobayas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radtriste Thanks! I sent an email about it to you, Mario and Daniele. Let's discuss there.

Please sign in to comment.