Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-rat-plugin license check for drools #6098

Closed
tkobayas opened this issue Sep 25, 2024 · 3 comments
Closed

apache-rat-plugin license check for drools #6098

tkobayas opened this issue Sep 25, 2024 · 3 comments
Assignees

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Sep 25, 2024

Running check against incubator-kie-10.0.0-rc1-sources.zip for incubator-kie-drools. (as of Sep 25, 2024)

mvn apache-rat:check

Reports missing license headers.

@tkobayas tkobayas self-assigned this Sep 25, 2024
@tkobayas tkobayas changed the title apache-rat-plugin license check apache-rat-plugin license check for drools Sep 25, 2024
@tkobayas
Copy link
Contributor Author

Files with unapproved licenses:

drools-docs/supplemental-ui/js/search-ui.js
kie-dmn/kie-dmn-xls2dmn-cli/dependency-reduced-pom.xml
kie-dmn/kie-dmn-ruleset2dmn-parent/kie-dmn-ruleset2dmn-cli/dependency-reduced-pom.xml
drools-drlonyaml-parent/drools-drlonyaml-cli/dependency-reduced-pom.xml
drools-drlonyaml-parent/drools-drlonyaml-model/src/test/resources/smoketests/ruleunit.drl.txt
drools-drlonyaml-parent/drools-drlonyaml-schemagen/dependency-reduced-pom.xml

@LightGuard
Copy link
Contributor

Are these things we ship with our sources? Actually, most are pom.xml files. The test file is probably fine, I think it breaks if we add the header to it. I don't think we ship the docs code.

@tkobayas
Copy link
Contributor Author

tkobayas commented Oct 2, 2024

@LightGuard Those files are included in incubator-kie-10.0.0-rc1-sources.zip. Anyway, dependency-reduced-pom.xml is generated code, so we simply exclude it. ruleunit.drl.txt was okay to add license (doesn't break a test), so added. search-ui.js already has Mozilla Public License header

@tkobayas tkobayas closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants