Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0.x] [incubator-kie-drools-6098] apache-rat-plugin license check for drools #6099

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[10.0.x] [incubator-kie-drools-6098] apache-rat-plugin license check for drools #6099

merged 1 commit into from
Sep 25, 2024

Conversation

tkobayas
Copy link
Contributor

tkobayas
tkobayas commented Sep 25, 2024
View reviewed changes
pom.xml
Comment on lines +139 to +143
<exclude>**/dependency-reduced-pom.xml</exclude>
<exclude>**/lunr-2.3.9.min.js</exclude>
<exclude>**/search-ui.js</exclude>
<exclude>**/branch.yaml</exclude>
<exclude>**/main.yaml</exclude>
Copy link
Contributor Author

@tkobayas tkobayas Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency-reduced-pom.xml is a generated file
search-ui.js has Mozilla Public License header
branch.yaml and main.yaml are overwritten by kogito-pipelines, so if we add a License header, it will be lost in the distribution sources.zip (let's treat them as generated files)

tkobayas
tkobayas commented Sep 25, 2024
View reviewed changes
pom.xml
@@ -159,7 +163,6 @@
<exclude>**/*.log</exclude>
<exclude>**/*.lst</exclude>
<exclude>**/checkstyle-cachefile</exclude>
<exclude>**/smoke*.drl.txt</exclude>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke*.drl.txt and ruleunit.drl.txt are checked by the apache-rat-plugin. They are not generated files, so I removed the exclusion and added license headers.

@tkobayas
Copy link
Contributor Author

tkobayas commented Sep 25, 2024 •
edited
Loading

Locally confirmed that mvn apache-rat:check was successful.

@baldimir @LightGuard @porcelli @mariofusco Please review. If merged, I'll forward port to main.

@tkobayas
Copy link
Contributor Author

For GHA: Drools Ansible RuleBook Integration Check, filed a GH issue:
#6100

@LightGuard
Copy link
Contributor

Looks fine. We don't distribute the docs with a release, so we don't have to have the license there, but not a problem if it is there.

@tkobayas tkobayas changed the title [incubator-kie-drools-6098] apache-rat-plugin license check for drools [10.0.x] [incubator-kie-drools-6098] apache-rat-plugin license check for drools Sep 25, 2024
@tkobayas tkobayas merged commit af468d3 into apache:10.0.x Sep 25, 2024
8 of 10 checks passed
tkobayas added a commit to tkobayas/drools that referenced this pull request Sep 25, 2024
@tkobayas
[incubator-kie-drools-6098] apache-rat-plugin license check for drools (
8c1234a 
apache#6099)
@tkobayas tkobayas mentioned this pull request Sep 25, 2024
Merged
tkobayas added a commit that referenced this pull request Sep 27, 2024
@tkobayas
[incubator-kie-drools-6098] apache-rat-plugin license check for drools (
5cdf554 
#6102)

* [incubator-kie-drools-6098] apache-rat-plugin license check for drools (#6099)

* Add missing license headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LightGuard LightGuard LightGuard approved these changes

@mariofusco mariofusco mariofusco approved these changes

@porcelli porcelli Awaiting requested review from porcelli

@baldimir baldimir Awaiting requested review from baldimir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkobayas @LightGuard @mariofusco