[DROOLS-7482] Experiment H2 persistence #5368

tkobayas · 2023-06-30T07:57:30Z

Add H2 MVStore persistence
Has some duplicate test cases with infinispan

JIRA:
https://issues.redhat.com/browse/DROOLS-7482

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
- for jenkins job: please add comment: Jenkins run fdb
- for github actions job: add the label run_fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

- Add H2 MVStore persistence - Has some duplicate test cases with infinispan

tkobayas · 2023-06-30T08:19:21Z

...s-reliability-h2mvstore/src/main/java/org/drools/reliability/h2mvstore/H2MVStoreStorage.java

+    @Override
+    public V put(K key, V value) {
+        V previousValue = mvMap.put(key, value);
+        mvMap.store.commit();


To persist data to a file, commit() has to be called. If we use SafepointStrategy.EXPLICIT or SafepointStrategy.AFTER_FIRE, we may optimize the commit calls (= commit only at the end of a batch call), but at the moment, I leave it.

Agreed that a batch commit will improve performances which is exactly what we wanted to achieve or at least experiment with H2. Please try to fix this before running benchmarks.

I have realized that this implementation already benefits from SafepointStrategy because it calls putAll instead of put.

tkobayas · 2023-06-30T08:22:55Z

...ls-reliability-h2mvstore/src/test/java/org/drools/reliability/h2mvstore/ReliabilityTest.java

+import static org.assertj.core.api.Assertions.assertThat;
+
+@ExtendWith(BeforeAllMethodExtension.class)
+class ReliabilityTest extends ReliabilityTestBasics {


As mentioned in gchat, test classes are duplicated with drools-reliability-infinispan. I think I will move tests to drools-reliability-tests as single place to test with different configurations. I'll do it in a separate JIRA.