[DROOLS-7488] tests - update rule action method in DRL #5381
Conversation
mariofusco
changed the title
| clearResults(session2); | ||
|
|
||
| Optional<FactHandle> getFactHandleForPerson = getFactHandle(session2, pEleven); | ||
| if (!getFactHandleForPerson.isEmpty()){ |
There was a problem hiding this comment.
If I'm not missing anything we always expect this Optional not to be empty, right? In case this is the expectation, the test should reflect it and fail with an empty Optional instead of simply silencing the problem as it does now.
There was a problem hiding this comment.
Yes, we expect that the Optional FactHandle will not be empty. Thanks for the suggestion, I will replace if-statement with an assertion so that the test will fail if the FactHandle is empty.
Thanks Mario, I changed the test and updated the PR. |
|
Kudos, SonarCloud Quality Gate passed!
|
JIRA: DROOLS-7488