Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-7501] avoid using TMS components when not strictly necessary #5393

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

mariofusco
Copy link
Contributor

@kie-ci4
Copy link
Contributor

kie-ci4 commented Jul 17, 2023

(tests) - drools job #1556 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=-Dfull -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/drools/main/.ci/buildchain-config.yaml' -o 'bc' -p kiegroup/drools -u https://github.com/kiegroup/drools/pull/5393 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/drools/job/main/job/pullrequest/job/drools.tests.drools/1556/display/redirect

Test results:

  • PASSED: 21677
  • FAILED: 3

Those are the test failures:

org.drools.serialization.protobuf.TruthMaintenanceTest.testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion
Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e>
org.drools.compiler.integrationtests.ErrorOnInsertLogicalTest.testErrorHandling expected:<[1]> but was:<[2]>
org.drools.mvel.compiler.beliefsystem.defeasible.DefeasibilityTest.testDefeaterPositiveVsNegative[KieBase type=CLOUD_IDENTITY] expected:<[3]> but was:<[2]>

@kie-ci4
Copy link
Contributor

kie-ci4 commented Jul 17, 2023

(tests) - drools job #1557 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=-Dfull -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/drools/main/.ci/buildchain-config.yaml' -o 'bc' -p kiegroup/drools -u https://github.com/kiegroup/drools/pull/5393 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/drools/job/main/job/pullrequest/job/drools.tests.drools/1557/display/redirect

Test results:

  • PASSED: 21679
  • FAILED: 1

Those are the test failures:

org.drools.mvel.compiler.beliefsystem.defeasible.DefeasibilityTest.testDefeaterPositiveVsNegative[KieBase type=CLOUD_IDENTITY] expected:<[3]> but was:<[2]>

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@mariofusco mariofusco merged commit b18aedf into apache:main Jul 17, 2023
11 checks passed
@mariofusco mariofusco deleted the d7501 branch July 17, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants