[DROOLS-7416] Add Invalidate RuleUnit method #5397
Conversation
| public <T extends RuleUnitData> int invalidateRuleUnits(Class<T> ruleUnitDataClass) { | ||
| String ruleUnitName = getRuleUnitName(ruleUnitDataClass); | ||
| RuleUnit remove = ruleUnitMap.remove(ruleUnitName); | ||
| return remove == null ? 0 : 1; |
There was a problem hiding this comment.
At the moment, I can think of only 0 or 1 as a return value in case of RuleUnitProviderImpl. Am I missing something? We use int as a return type for a future implementation of RuleUnitProvider? @mariofusco
There was a problem hiding this comment.
If the rule unit is a NamedRuleUnitData you could have multiple entries in the ruleUnitMap cache of rule units coming from the same class and you should remove all of them. I believe that at the moment the only correct way to do so is iterating the values of the map and removing all the entries of rule units coming from that class. Please also add a test case for this scenario.
There was a problem hiding this comment.
@mariofusco Thank you for raising the use case! Test added.
|
Kudos, SonarCloud Quality Gate passed! |
* [DROOLS-7416] Invalidate RuleUnit * - invalidate multiple named rule units test
JIRA:
https://issues.redhat.com/browse/DROOLS-7416
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.