-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PersistenceObjectStrategy option #5418
Conversation
(tests) - serverless-workflow-examples job Reproducerexport BUILD_MVN_OPTS_CURRENT= NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Test results:
Those are the test failures: none See console log: Console Logs[2023-07-31T16:27:43.347Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)[2023-07-31T16:27:43.347Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.347Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.347Z] Caused by: org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.347Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:357) [2023-07-31T16:27:43.347Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.347Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.347Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.347Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.347Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.347Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.347Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.347Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.347Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.347Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.347Z] Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.347Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:425) [2023-07-31T16:27:43.347Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:229) [2023-07-31T16:27:43.347Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:340) [2023-07-31T16:27:43.347Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.347Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.348Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.348Z] Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.348Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:415) [2023-07-31T16:27:43.348Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:229) [2023-07-31T16:27:43.348Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:340) [2023-07-31T16:27:43.348Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.348Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.348Z] [ERROR] Failed to execute goal on project serverless-workflow-python-quarkus: Could not resolve dependencies for project org.kie.kogito.examples:serverless-workflow-python-quarkus:jar:1.0-SNAPSHOT: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT -> [Help 1] [2023-07-31T16:27:43.348Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project serverless-workflow-python-quarkus: Could not resolve dependencies for project org.kie.kogito.examples:serverless-workflow-python-quarkus:jar:1.0-SNAPSHOT: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:269) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.348Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.348Z] Caused by: org.apache.maven.project.DependencyResolutionException: Could not resolve dependencies for project org.kie.kogito.examples:serverless-workflow-python-quarkus:jar:1.0-SNAPSHOT: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.348Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:214) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.348Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.348Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.348Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.348Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.348Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.348Z] Caused by: org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.348Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:357) [2023-07-31T16:27:43.348Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.348Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.349Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.349Z] Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:425) [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:229) [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:340) [2023-07-31T16:27:43.349Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.349Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.349Z] Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-addons-quarkus-serverless-workflow-python:jar:2.0.0-SNAPSHOT [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:415) [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:229) [2023-07-31T16:27:43.349Z] at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies (DefaultRepositorySystem.java:340) [2023-07-31T16:27:43.349Z] at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:207) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:401) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:347) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) [2023-07-31T16:27:43.349Z] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) [2023-07-31T16:27:43.349Z] at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) [2023-07-31T16:27:43.349Z] at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) [2023-07-31T16:27:43.349Z] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) [2023-07-31T16:27:43.349Z] at java.lang.reflect.Method.invoke (Method.java:566) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) [2023-07-31T16:27:43.349Z] at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) [2023-07-31T16:27:43.349Z] [ERROR] [2023-07-31T16:27:43.349Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging. [2023-07-31T16:27:43.349Z] [ERROR] [2023-07-31T16:27:43.349Z] [ERROR] For more information about the errors and possible solutions, please read the following articles: [2023-07-31T16:27:43.349Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException [2023-07-31T16:27:43.349Z] [ERROR] [2023-07-31T16:27:43.349Z] [ERROR] After correcting the problems, you can resume the build with the command [2023-07-31T16:27:43.349Z] [ERROR] mvn -rf :serverless-workflow-openvino-quarkus [2023-07-31T16:27:46.698Z] [INFO] kiegroup/kogito-examples failed. Won't execute remaining commands and projects [2023-07-31T16:27:46.698Z] [INFO] Execution summary for kiegroup/kogito-examples [2023-07-31T16:27:46.698Z] # [BEFORE] [kiegroup/kogito-examples] export INTEGRATION_BRANCH= [2023-07-31T16:27:46.698Z] [INFO] OK [Executed in 0.059221 ms] [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] # [BEFORE] [kiegroup/kogito-examples] bash -c "if [ ! -z '' ] && [ -f .ci/environments/update.sh ]; then .ci/environments/update.sh ; fi" [2023-07-31T16:27:46.698Z] [INFO] OK [Executed in 6.224894 ms] [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] # [COMMANDS] [kiegroup/kogito-examples] export MVN_CMD=`bash -c "if [ '' = 'true' ]; then printf 'deploy '; else printf 'install'; fi"` [2023-07-31T16:27:46.698Z] [INFO] OK [Executed in 7.266227 ms] [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] # [COMMANDS] [kiegroup/kogito-examples] mvn -pl :kogito-examples clean install -s /home/jenkins/workspace/KIE/drools/main/pullrequest/drools.tests.downstream.serverless-workflow-examples@tmp/config13791965019656351728tmp -Dmaven.wagon.http.ssl.insecure=true -Dmaven.test.failure.ignore=true -nsu -ntp -fae -e -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dmaven.wagon.http.retryHandler.count=3 dependency:tree -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -B [2023-07-31T16:27:46.698Z] [INFO] OK [Executed in 7770.3238440000005 ms] [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] # [COMMANDS] [kiegroup/kogito-examples] mvn -f serverless-workflow-examples/pom.xml clean install -s /home/jenkins/workspace/KIE/drools/main/pullrequest/drools.tests.downstream.serverless-workflow-examples@tmp/config13791965019656351728tmp -Dmaven.wagon.http.ssl.insecure=true -Dmaven.test.failure.ignore=true -nsu -ntp -fae -e -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dmaven.wagon.http.retryHandler.count=3 dependency:tree -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -B [2023-07-31T16:27:46.698Z] [INFO] NOT OK [Executed in 1049488.388643 ms] [2023-07-31T16:27:46.698Z] [ERROR] The process '/opt/tools/apache-maven-3.8.7/bin/mvn' failed with exit code 1 [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] [INFO] [AFTER] Skipped kiegroup/kogito-examples [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] # Uploading artifacts [2023-07-31T16:27:46.698Z] [INFO] Will not upload any artifacts in CLI environment [2023-07-31T16:27:46.698Z] [2023-07-31T16:27:46.698Z] [ERROR] Failed to execute commands for kiegroup/kogito-examples [2023-07-31T16:27:46.698Z] [ERROR] Failed to execute mvn -f serverless-workflow-examples/pom.xml clean install -s /home/jenkins/workspace/KIE/drools/main/pullrequest/drools.tests.downstream.serverless-workflow-examples@tmp/config13791965019656351728tmp -Dmaven.wagon.http.ssl.insecure=true -Dmaven.test.failure.ignore=true -nsu -ntp -fae -e -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dmaven.wagon.http.retryHandler.count=3 dependency:tree -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -B : [2023-07-31T16:27:46.698Z] [ERROR] The process '/opt/tools/apache-maven-3.8.7/bin/mvn' failed with exit code 1 [Pipeline] } [Pipeline] // withCredentials [Pipeline] } [2023-07-31T16:27:46.773Z] Deleting 1 temporary files [Pipeline] // configFileProvider [Pipeline] } [Pipeline] // script Post stage [Pipeline] script [Pipeline] { [Pipeline] sh [2023-07-31T16:27:47.185Z] + find . -type d -name node_modules -exec rm -rf '{}' ';' [Pipeline] junit [2023-07-31T16:27:47.463Z] Recording test results [2023-07-31T16:27:49.197Z] [Checks API] No suitable checks publisher found. [Pipeline] archiveArtifacts [2023-07-31T16:27:49.215Z] Archiving artifacts [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh [2023-07-31T16:27:50.738Z] + rm -rf console.log [Pipeline] sh [2023-07-31T16:27:51.033Z] + wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/drools/job/main/job/pullrequest/job/drools.tests.downstream.serverless-workflow-examples/797/consoleText [2023-07-31T16:27:51.034Z] + tail -n 300 |
@@ -0,0 +1,87 @@ | |||
package org.drools.reliability.test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
@@ -0,0 +1,86 @@ | |||
package org.drools.reliability.core; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
@@ -0,0 +1,39 @@ | |||
package org.drools.reliability.core; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
@@ -0,0 +1,21 @@ | |||
package org.test.domain.fireandalarm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
@@ -0,0 +1,27 @@ | |||
package org.test.domain.fireandalarm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
@@ -0,0 +1,6 @@ | |||
package org.test.domain.fireandalarm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
@@ -0,0 +1,35 @@ | |||
package org.test.domain.fireandalarm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tkobayas, copyright header added.
private StoredObject factHandleToStoredObject(InternalFactHandle handle, boolean propagated, Object object) { | ||
StoredObject factHandleToStoredObject(InternalFactHandle handle, boolean propagated, Object object) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably protected
is more suitable here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, thank you.
private void updateReferencedObjects(StoredObject object){ | ||
List<Field> referencedObjects = getReferencedObjects(object.getObject()); | ||
if (referencedObjects.size()>0) { | ||
|
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not used, so should be removed? Please check SonarCloud suggestions in this PR (sometimes there are unacceptable suggestions, though). Also you can add SonarLint plugin in your local IDE to notice such suggestions earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I noticed that is not used, it seems that its implementation is not complete that's why I left it there to see what else is missing. However, I can remove it and add it back if needed.
Thank you for the suggestion for the plugin, I didn't have this in mind:)
failover(); | ||
restoreSession(FIRE_AND_ALARM, persistenceStrategy,safepointStrategy,PersistedSessionOption.PersistenceObjectsStrategy.OBJECT_REFERENCES); | ||
|
||
assertThat(fireAllRules()).isEqualTo(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asserting only fire count is not good enough. Possible additional assertions:
- Use global
results
to collect fired rule names and assert - Assert expected object state. in this case,
Sprinkler.on
istrue
.Alarm
exists in the working memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, this is a very basic test, I will improve it and add more tests as needed.
Good job, @nprentza . Posted some minor comments. Thanks! |
@nprentza Also please mind formatting codes. If you use Eclipse or Intellij IDEA, https://github.com/kiegroup/droolsjbpm-build-bootstrap/tree/main/ide-configuration would help. |
try { | ||
fieldObject = field.get(object.getObject()); | ||
} catch (IllegalAccessException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repropagate this exception as a runtime one instead of simply printing the stack trace and swallow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mariofusco, I will change this to throw a ReliabilityRuntimeException
|
||
List<Field> nonPrimitiveFields = Arrays.stream(fields) | ||
.filter(field -> !field.getType().isPrimitive()) | ||
.filter(field -> !field.getType().equals(String.class)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of filtering on the type of the field probably here it should keep only the fields having a value that is also an object inserted in the session, or in other words an object that is also present in the objects store (not sure how easy would be to check this though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, good idea, thanks @mariofusco
I introduced a uniqueObjectTypesInStore
object to maintain the classes of objects inserted in the store. Every time an object is inserted or removed from the persisted store,uniqueObjectTypesInStore
is updated accordingly. Then, the filtering of the field types is done by looking into the list with the unique object types in the store.
Kudos, SonarCloud Quality Gate passed! 0 Bugs 89.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
JIRA [DROOLS-7512] (https://issues.redhat.com/browse/DROOLS-7512)