Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DROOLS-7527] Alyways use AbstractTuple instead of Tuple (Fix the secondary super cache problem in Drools) #5447

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[DROOLS-7527] Alyways use AbstractTuple instead of Tuple (Fix the secondary super cache problem in Drools) #5447

merged 2 commits into from
Aug 9, 2023

Conversation

lucamolteni
Copy link
Contributor

This one is less "clean" than (https://github.com/kiegroup/drools/pull/5443) as AbstractTuple is only used in next (and in previous it's stille Tuple). Also the Tuple interface is too spread to be removed entirely.

Alyways use AbstractTuple instead of Tuple (Fix the secondary super cache problem in Drools)

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@lucamolteni lucamolteni changed the title First commit removing Tuple for AbstractTuple in next Replace Tuple with AbstractTuple Aug 7, 2023
mariofusco
mariofusco reviewed Aug 7, 2023
View reviewed changes
drools-core/src/main/java/org/drools/core/reteoo/Tuple.java Outdated
@@ -111,13 +111,13 @@ default boolean isDeleted() {

Tuple skipEmptyHandles();

LeftTuple getFirstChild();
AbstractLeftTuple getFirstChild();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if understandable, being the main point of this pull request, as discussed I find a bit unfortunate that now Tuple has to depend on AbstractTuple. The solution would be to totally remove this not really useful interface and rename AbstractTuple into Tuple, keeping it an abstract class, but I agree that this refactor could be implemented with a subsequent separated pull request.

@lucamolteni lucamolteni changed the title Replace Tuple with AbstractTuple [DROOLS-7527] Alyways use AbstractTuple instead of Tuple (Fix the secondary super cache problem in Drools) Aug 8, 2023
@kie-ci4
Copy link
Contributor

kie-ci4 commented Aug 8, 2023

(tests) - serverless-workflow-examples job #831 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/drools/main/.ci/buildchain-config.yaml' -o 'bc' -p kiegroup/kogito-examples -u https://github.com/kiegroup/drools/pull/5447 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/drools/job/main/job/pullrequest/job/drools.tests.downstream.serverless-workflow-examples/831/display/redirect

Test results:

  • PASSED: 81
  • FAILED: 1

Those are the test failures:

org.kie.kogito.examples.OpenVinoRestIT.testOpenvino 1 expectation failed.
JSON path workflowdata.group doesn't match.
Expected: a string containing "flat-coated retriever"
Actual: <[]>

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mariofusco mariofusco merged commit f83ff41 into apache:main Aug 9, 2023
11 checks passed
lucamolteni added a commit to lucamolteni/drools that referenced this pull request Sep 14, 2023
@lucamolteni
Revert "[DROOLS-7527] Alyways use AbstractTuple instead of Tuple (Fix…
21371f2 
… the secondary super cache problem in Drools) (apache#5447)"

This reverts commit f83ff41
lucamolteni added a commit to lucamolteni/drools that referenced this pull request Oct 11, 2023
@lucamolteni
[DROOLS-7527] Alyways use AbstractTuple instead of Tuple (Fix the sec…
383c654 
…ondary super cache problem in Drools) (apache#5447)

* First commit removing Tuple for AbstractTuple as next

* Cast to AbstractTuple in the FromNode

(cherry picked from commit f83ff41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkobayas tkobayas tkobayas approved these changes

@mariofusco mariofusco mariofusco approved these changes

@pibizza pibizza Awaiting requested review from pibizza

@mdproctor mdproctor Awaiting requested review from mdproctor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucamolteni @kie-ci4 @mariofusco @tkobayas