[DROOLS-7608] fix KieProject lookup on classpath for EAP 7.4.15 VFS #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tkobayas This is only a rewritten and cleaned up version of the solution that you found here.
I dug into VFS sources a lot and couldn't find any better solution. I understand that using reflection is not ideal, but in the end we were already doing so, even if just because we didn't want a direct dependency on VFS. Now it's true that this is a bit worse than before because we're also accessing package private methods (that are probably subject to change in future), but other than asking the Jboss team to make those methods public, thus avoiding to use
setAccessible(true), I don't see any possible improvement.