-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-drools#5758] Update drools-docs for v10 #5770
[incubator-kie-drools#5758] Update drools-docs for v10 #5770
Conversation
4a27c4e
to
b98ab2e
Compare
@baldimir @mariofusco Please review, thanks! This PR is just to make the docs consistent with version 10 instead of version 8. If we will make a big change and/or integrate with the new website, it would be another issue/PR. |
|
||
Maven `3.8.6` is now the minimum Maven version required to build Drools from source, or using `kie-ci` APIs. | ||
Maven `3.8.6` is the minimum Maven version required to build Drools from source, or using `kie-ci` APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the minimal Maven version is now 3.9.3. Is that correct @jstastny-cz please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drools itself is 3.8.6
https://github.com/apache/incubator-kie-drools/blob/main/build-parent/pom.xml#L89
But actually, our GHA runs with 3.9.3
to meet Quarkus 3.2 LTS <proposed-maven-version>3.9.3</proposed-maven-version>
.
I'm good with changing the doc to 3.9.3
as a requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarification. Then I think the doc is fine. If we will find that the Maven version would be good to update, it can be done in a separate PR.
Issue:
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdb
for Jenkins PR check only
Build Now
button.