Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-parser] Match EOF at the end of the compilation unit #5930

Merged
merged 1 commit into from
May 13, 2024

Conversation

yurloc
Copy link
Contributor

@yurloc yurloc commented May 12, 2024

Without the EOF, the parser has no incentive to continue processing input once it encounters a "broken" DRL statement keyword.

For example, if there is a typo in the import statement (impot), the parser is simply unable to match drlStatement and it "gracefully" quits without reporting any error. Explained in more detail at https://github.com/antlr/antlr4/blob/master/doc/parser-rules.md#start-rules-and-eof.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@yurloc
Copy link
Contributor Author

yurloc commented May 13, 2024

@mariofusco @tkobayas @gitgabrio please review.

@mariofusco mariofusco merged commit 879f65c into apache:dev-new-parser May 13, 2024
0 of 3 checks passed
@yurloc yurloc deleted the new-parser-eof branch May 13, 2024 08:10
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants