[DROOLS-7197] fix generics introspection on superclasses during exec … #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
commented
May 14, 2024
| @@ -164,59 +162,6 @@ public void setter_intToPrimitiveLongCoercionVarargs() { | |||
| assertThat(fact.getValueList()).containsExactly(10L, 20L); // Coerced with both cases | |||
| } | |||
|
|
|||
| @Test | |||
| public void property_subClassMethod_genericsReturnType() { | |||
There was a problem hiding this comment.
Since this is no longer a difference between interpreted mode and executable model I moved these 2 tests in a different class.
mariofusco
commented
May 14, 2024
| } else { | ||
| return Optional.empty(); | ||
| } | ||
| private static boolean typeNeedsCast(Type t) { |
There was a problem hiding this comment.
The Optional wasn't really necessary here since the result was used only as a boolean testing if the Optional was present or not.
mariofusco
commented
May 14, 2024
| } else { | ||
| return new TypedExpressionCursor(methodCallExpr, genericReturnType); | ||
| } | ||
| return new TypedExpressionCursor(methodCallExpr, actualTypeFromGenerics(originalTypeCursor, m.getGenericReturnType(), rawClassCursor)); |
There was a problem hiding this comment.
All the logic to deal with generics introspection has been moved in static utility methods of ClassUtils.
lucamolteni
approved these changes
May 14, 2024
tkobayas
approved these changes
May 15, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jun 10, 2024
…model generation (apache#5944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both problems reported in #5925 and https://issues.redhat.com/browse/DROOLS-7197